Introduce common::memory
#3957
Draft
Introduce common::memory
#3957
+357
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnellerhase
force-pushed
the
schnellerhase/memory
branch
from
8cb6059 to
133f7a7
Compare
schnellerhase
requested review from
chrisrichardson,
jorgensd and
michalhabera
|
This is not yet ready for a proper review, but before extending the interface to more heavy types I wanted to check if this was the right way to go about implementing this interface or if this approach misses some important capabilities we would like to see. In particular the python side is still very rough, and something along the lines of https://github.com/timlnx/bitmath/, would be very desirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces free function
common::memory. Which provides a unit based access (inB,KB,MB, ...) to the implementation detailcommon::impl::memory, which computes for given types the used memory in bytes. This needs to be implemented for every type of which one wants to have access to a memory consumption (and its member types!).This provides a user controllable memory profiling capability, up to a desired/required precision.
First step towards #1741.